Difference between revisions of "Talk:Patch for controlling fan speed"

From ThinkWiki
Jump to: navigation, search
(→‎whats the problem kernel 2.6.14)
m (→‎Using sudo: fix example usage of /proc/acpi/ibm/fan)
 
(9 intermediate revisions by 8 users not shown)
Line 1: Line 1:
 +
==Using sudo==
 +
Any idea why I have to use '''sudo -s''' first instead of just using '''sudo <command>'''?
 +
 +
* Just using {{cmduser|sudo echo level 5 > /proc/acpi/ibm/fan}} runs the echo command as root, but the writing to the proc file is done as your user. Running {{cmduser|sudo -s}} gives you a root shell where the write to the fan file is done as root. - [[User:Kelsin|Kelsin]] 01:16, 17 August 2008 (CEST)
 +
* One might, however, do {{cmduser|sudo sh -c 'echo level 5 > /proc/acpi/ibm/fan'}} instead.
 +
 
==Windows XP port==
 
==Windows XP port==
 
How would I port this patch to Windows XP?  
 
How would I port this patch to Windows XP?  
Line 41: Line 47:
  
 
== Updated script for unpatched kernels ==
 
== Updated script for unpatched kernels ==
 +
Moved to the [[ACPI fan control script]] article page, after joint development by [[User:Spiney|Spiney]] and [[User:Thinker|Thinker]].
  
−
A couple of command line options added, plus this version is able to daemonize and writes a pid file (to a custom location if needed). It's for an unpatched version of the kernel, since I think that's the way to go, but it should be easy to merge into the other version as well since it doesn't change any internals.
+
== whats the problem kernel 2.6.14 ==
  
−
Any feedback appreciated.
+
hi all,
  
−
Here we go:
+
i patched the kernel with the patch for 2.6.14 with the option:
 +
/usr/src/linux # patch -p0 -l -i ../ibm_acpi.patch (which i copy&pasted)
  
−
<pre>
+
they dont show me errors or so. but after i reboot and load the modul ibm_acpi i cant see any /proc/acpi/ibm/fan
−
#!/bin/bash
 
  
−
# This script dynamically controls fan speed on some ThinkPad models
+
whats the problem? copy&past ( tab -> space?)
−
# according to user-defined temperature thresholds.  It implements its
+
or is it a problem in my kernel config?
−
# own decision algorithm, overriding the ThinkPad embedded
 
−
# controller. It also implements a workaround for the fan noise pulse
 
−
# experienced every few seconds on some ThinkPads.
 
−
#
 
−
# WARNING: This script relies on undocumented hardware features and
 
−
# overrides nominal hardware behavior. It may thus cause arbitrary
 
−
# damage to your laptop or data. Watch your temperatures!
 
−
#
 
−
# This file is placed in the public domain and may be freely distributed.
 
  
−
LEVELS=(    0      2      4      7)  # Fan speed levels
+
greetings and big thx from .ch,
−
UP_TEMPS=(      52    60    68  )  # Speed increase trip points
 
−
DOWN_TEMPS=(  48    56    64    )  # Speed decrease trip points
 
  
−
ANTIPULSE=( 0      1      0      0)  # Prevent fan pulsing noise at this level
 
−
                                    #  (this also prevents fan speed updates)
 
  
−
IBM_ACPI=/proc/acpi/ibm
+
system: ibm thinkpad t43p
−
PID_FILE=/var/run/tp-fancontrol.pid
+
kernel: 2.6.14
−
INTERVAL=3
 
−
VERBOSE=true
 
−
DRY_RUN=false
 
−
DAEMONIZE=false
 
  
−
usage() {
+
--[[User:62.203.29.204|62.203.29.204]] 19:22, 9 Nov 2005 (CET)kru
−
        echo "Usage: $0 [OPTION]..."
 
−
        echo
 
−
        echo "Available options:"
 
−
        echo "  -t    test mode"
 
−
        echo "  -q    quiet mode"
 
−
        echo "  -d    daemon mode, go into background, implies -q"
 
−
        echo "  -p    pid file location for daemon mode, default: $PID_FILE"
 
−
exit 1
 
−
}
 
  
−
while getopts 'qtdp:h' OPT; do
+
You need to pass the "<tt>experimental=1</tt>" module parameter to ibm-acpi:
−
        case "$OPT" in
+
# modprobe ibm_acpi experimental=1
−
                t)
+
--[[User:Thinker|Thinker]] 21:01, 9 Nov 2005 (CET)
−
                        DRY_RUN=true
 
−
                        ;;
 
−
                q) # quiet mode
 
−
                        VERBOSE=false
 
−
                        ;;
 
−
                d) # go into background and daemonize
 
−
                        DAEMONIZE=true
 
−
                        ;;
 
−
                p) # different pidfile
 
−
                        PID_FILE="$OPTARG"
 
−
                        ;;
 
−
                h) # short help
 
−
                        usage
 
−
                        ;;
 
−
                \?) # error
 
−
                        usage
 
−
                        ;;
 
−
        esac
 
−
done
 
−
[[ $OPTIND -gt $# ]] || usage  # no non-option args
 
−
 
 
−
if $DRY_RUN; then
 
−
        echo "$0: Dry run, will not change fan state."
 
−
        VERBOSE=true
 
−
        DAEMONIZE=false
 
−
fi
 
−
 
 
−
if $DAEMONIZE ; then
 
−
        if [[ -e "$PID_FILE" ]]; then
 
−
                echo "$0: File $PID_FILE already exists, refusing to run."
 
−
                exit 1
 
−
        else
 
−
                exec $0 -q -p "$PID_FILE" 0<&- 1>&- 2>&- &
 
−
                echo $! > "$PID_FILE"
 
−
                exit 0
 
−
        fi
 
−
fi
 
−
 
 
−
 
 
−
# Enable the fan in default mode if anything goes wrong:
 
−
set -e -E -u
 
−
$DRY_RUN || trap "rm -f $PID_FILE 2> /dev/null; echo enable > $IBM_ACPI/fan; exit 0" EXIT HUP INT ABRT QUIT SEGV TERM
 
−
 
 
−
 
 
−
thermometer() { # output list of temperatures
 
−
    read X Y < $IBM_ACPI/thermal
 
−
    if ! [[ "$X" == "temperatures:" ]]; then
 
−
        echo "$0: Bad temperatures: $X $Y" >&2
 
−
        exit 1
 
−
    fi
 
−
    echo "$Y";
 
−
}
 
−
 
 
−
speedometer() { # output fan speed RPM
 
−
    sed -n 's/^speed:[ \t]*//p' $IBM_ACPI/fan
 
−
}
 
−
 
 
−
setlevel() { # set fan speed level
 
−
    $DRY_RUN || echo 0x2F $1 > $IBM_ACPI/ecdump
 
−
}
 
−
 
 
−
IDX=0
 
−
MAX_IDX=$(( ${#LEVELS[@]} - 1 ))
 
−
SETTLE=0
 
−
 
 
−
while true; do
 
−
    TEMPS=`thermometer`
 
−
    $VERBOSE && SPEED=`speedometer`
 
−
 
 
−
    # Calculate new level
 
−
    NEWIDX=$IDX
 
−
    DOWN=$(( IDX > 0 ))
 
−
    for TEMP in $TEMPS; do
 
−
        # Increase speed as much as needed
 
−
        while [[ $NEWIDX -lt $MAX_IDX ]] &&
 
−
              [[ $TEMP -ge ${UP_TEMPS[$NEWIDX]} ]]; do
 
−
            (( NEWIDX ++ ))
 
−
            DOWN=0
 
−
        done
 
−
        # Allow decrease (by one index)?
 
−
        if [[ $DOWN == 1 ]] &&
 
−
          [[ $TEMP -gt ${DOWN_TEMPS[$(( IDX - 1 ))]} ]]; then
 
−
            DOWN=0
 
−
        fi
 
−
    done
 
−
    if [[ $DOWN == 1 ]]; then
 
−
        NEWIDX=$(( IDX - 1 ))
 
−
    fi
 
−
 
 
−
    # Transition
 
−
    OLDLEVEL=${LEVELS[$IDX]}
 
−
    NEWLEVEL=${LEVELS[$NEWIDX]}
 
−
    $VERBOSE && echo "tpfan: Temps: $TEMPS  Fan: $SPEED  Level: $OLDLEVEL->$NEWLEVEL"
 
−
    setlevel $NEWLEVEL
 
−
 
 
−
    sleep $INTERVAL
 
−
 
 
−
    # If needed, apply anti-pulsing hack after a settle-down period:
 
−
    if [[ ${ANTIPULSE[${NEWIDX}]} == 1 ]]; then
 
−
        if [[ $NEWLEVEL == $OLDLEVEL ]]; then
 
−
            if [[ $SETTLE -ge 0 ]]; then
 
−
                (( SETTLE -= INTERVAL ))
 
−
            else
 
−
                setlevel 0x40 # disengaged
 
−
                sleep 0.5
 
−
            fi
 
−
        else
 
−
            SETTLE=6
 
−
        fi
 
−
    fi
 
−
 
 
−
    IDX=$NEWIDX
 
−
done
 
−
</pre>
 
−
 
 
−
As usual, I disclaim all warranty for this script, and release it to the public domain (meaning you may use and further distribute it under any terms you wish, including incorporating it into other software).
 
−
 
 
−
--[[User:Spiney|Spiney]], Nov 7 2005, 19:46 (CET)
 
−
----
 
−
 
 
−
Hi,
 
−
 
 
−
I made a few changses (in your code above, for easy diff) to make the opt parsing safer and improve daemon mode. The indentation needs to be made consistently 4, but I didn't fix that to avoid trashing the diff.
 
−
 
 
−
--[[User:Thinker|Thinker]] 13:37, 8 Nov 2005 (CET)
 
−
----
 
−
 
 
−
Thanks for the cleanup, I just cut'n'paste parts from ancient scripts of mine into it. ;) About the indentation, I usually prefer tabs and had tw=8 in vim at the moment I pasted into the Wiki. Unfortunately it's not possible to use tabs here...
 
−
 
 
−
BTW, I tried to add some sort of logging of level changes to syslog, using logger and a line like
 
−
 
 
−
<pre>
 
−
[ -f $PID_FILE ] && [ $OLDLEVEL != $NEWLEVEL ] && /usr/bin/logger -i -t `basename $0` "Level: $OLDLEVEL->$NEWLEVEL"
 
−
</pre>
 
−
 
 
−
(using the existance of the pidfile as crude check whether we run in daemon mode) just below the normal verbose output ("tpfan: ....") and the interesting thing is that the PID is changing in the logged lines, any idea why?
 
−
 
 
−
--[[User:spiney|spiney]], still wondering how to get this signature added automatically, being not all that adept in Wikis
 
−
----
 
−
 
 
−
Using the $PID_FILE existence as a check isn't a good idea, even non-daemonized instances will use the syslog. Maybe that explains the PID change?
 
−
 
 
−
Speaking of which, a more elegant way to daemonize is to put the main loop in a function, and then use
 
−
main 0<&- ... &
 
−
instead of
 
−
exec $0 0<&- ... &"
 
−
 
 
−
BTW, <tt>[ -f $PIDFILE ]</tt> unnecessarily invokes the <tt>[</tt> binary. Better to use bash's built-in version (<tt><nowiki>[[ ... ]]</nowiki></tt>).
 
−
 
 
−
For the signature, just type <tt><nowiki>--~~~~</nowiki></tt> or click the 2nd-from-right button above the Wiki edit box.
 
−
 
 
−
--[[User:Thinker|Thinker]] 17:16, 8 Nov 2005 (CET)
 
−
----
 
−
 
 
−
Of course $PID_FILE is not a good idea as check, hence the word 'crude'. ;) Probably adding an option -l for logging would do.
 
−
 
 
−
The backgrounding of the function is a very good idea, I'll incorporate that.
 
−
 
 
−
Regarding the usage of [, it's a builtin as well, isn't it? And strace-ing a testscript doesn't show a call of {{path|/usr/bin/[|}} which is probably just shipped nowadays in case someone uses an ancient shell. In any case, never mind me talking about a change of PID, logger uses it's own PID when using -i, so of course it's different every time it's called. Easily amended by using $$ in the text supplied to the -t option of logger.
 
−
 
 
−
And thanks for the tip about the signature, I should pay more attention to the GUI parts of websites. :)
 
  
−
--[[User:Spiney|spiney]] 17:42, 8 Nov 2005 (CET)
+
big thx!!! problem solved.
−
----
 
  
−
Yeah, the <tt>logger</tt> PID explains it... And you're right about <tt>[</tt> - strange, the only difference between <tt>[ expr ]</tt> and <tt><nowiki>[[ expr ]]</nowiki></tt> seems to be a slightly difference syntax, and that the former is a "builtin" whereas the latter is a "compound command" (whatever that means). BTW, I guess this discussion should have been in the Talk page of the script, not the patch.
+
--[[User:62.203.29.204|62.203.29.204]]
  
−
--[[User:Thinker|Thinker]] 17:55, 8 Nov 2005 (CET)
+
== Fan control does not work with Suse 10.1 ? ==
−
----
 
  
−
Of course, silly me, no idea why I chose this page. I'll just put an updated version of the script there, and these comments can be deleted afterwards I guess.
+
Hi,  
  
−
--[[User:Spiney|spiney]] 18:11, 8 Nov 2005 (CET)
+
I successfully installed and used the fan control script on my T43p with Suse 10.0.
−
----
 
  
−
== whats the problem kernel 2.6.14 ==
+
Yesterday, I installed Suse 10.1 from scratch. Unfortunately fan control does not work with Suse 10.1:
  
−
hi all,
+
\# echo level 2 > /proc/acpi/ibm/fan
 +
bash: echo: write error: Invalid argument
  
−
i patched the kernel with the patch for 2.6.14 with the option:
+
Are there any substantial differences between Suse 10.0 and 10.1 with respect to ibm_acpi?
−
/usr/src/linux # patch -p0 -l -i ../ibm_acpi.patch (which i copy&pasted)
 
−
 
 
−
they dont show me errors or so. but after i reboot and load the modul ibm_acpi i cant see any /proc/acpi/ibm/fan
 
  
−
whats the problem? copy&past ( tab -> space?)
+
* You need to pass the fan_control=1 parameter to the thinkpad_acpi module when it's loaded into the kernel. This can be done manually with
−
or is it a problem in my kernel config?
 
  
−
greetings and big thx from .ch,
+
# modprobe thinkpad_acpi fan_control=1
  
 +
You'll have to read up on suse config to figure out how to do that automatically. With Gentoo it involves putting a file in {{path|/etc/modprobe.d/}} then running {{cmdroot|update-modules}} to have it update {{path|/etc/modprobe.conf}}. Other distros might have you just edit {{path|/etc/modprobe.conf}} directly but I wouldn't know. - [[User:Kelsin|Kelsin]] 01:16, 17 August 2008 (CEST)
  
−
system: ibm thinkpad t43p
+
== Speed Control Patch for 2.6.18? ==
−
kernel: 2.6.14
 
  
−
--[[User:62.203.29.204|62.203.29.204]] 19:22, 9 Nov 2005 (CET)kru
+
Hi All.
 +
I'm trying to apply the speed control patch to vanilla 2.6.18 but it looks like it failed. Anyone who can point me to a direction for 2.6.18 patch?
 +
Thanks
  
−
You need to pass the "<tt>experimental=1</tt>" module parameter to ibm-acpi:
+
== ibm-acpi-0.12a-2.6.17-fan.patch broken? ==
−
# modprobe ibm_acpi experimental=1
+
The code is not completed.
−
--[[User:Thinker|Thinker]] 21:01, 9 Nov 2005 (CET)
 

Latest revision as of 17:55, 19 August 2008

Using sudo

Any idea why I have to use sudo -s first instead of just using sudo <command>?

  • Just using $ sudo echo level 5 > /proc/acpi/ibm/fan runs the echo command as root, but the writing to the proc file is done as your user. Running $ sudo -s gives you a root shell where the write to the fan file is done as root. - Kelsin 01:16, 17 August 2008 (CEST)
  • One might, however, do $ sudo sh -c 'echo level 5 > /proc/acpi/ibm/fan' instead.

Windows XP port

How would I port this patch to Windows XP?

--Jason

You can't. But you can write a Windows device driver based on the specs and ibm-acpi.

--Thinker 18:54, 7 Nov 2005 (CET)

gkrellm support

I can confirm that it works on Thinkpad T43 here. However after applying the patch, the fan speed monitor of gkrellm 2.2.7 cannot read value correctly. Maybe we gkrellm is reading the second line for speed but instead find the line for level, so it got confused? Would it be possible to interchange the lines so that speed still appears in the second line and level appears in the third instead? I'm no coder, just a suggestion to improve the patch.

--Jiang

I'd say it's a bug in gkrellm. It should parse the line header rather than relying on line numbers. But feel free to change (and test) the patch if you wish.

--Thinker 05:14, 26 Oct 2005 (CEST)

patch to keep gkrell working against 2.6.14

As in "works for me on a T43p", use with caution at your own risk. And thanks to thinker for the original patch, very nice work.

(See article for the actual patch)

--Spiney

Looks excellent, why not add it to the article page? Also, care to provide a license (preferably public domain like my patch) so the kernel guys can handle it? Speaking of which, the kernel people seem to like their patches generated via "diff -up vanilla-kernel-2.6.14 patched-kernel-2.6.14".

--Thinker 22:04, 1 Nov 2005 (CET)

Done, using the -p option for diff and "borrowing" your sentence for licensing purposes.

--Spiney

Updated script for unpatched kernels

Moved to the ACPI fan control script article page, after joint development by Spiney and Thinker.

whats the problem kernel 2.6.14

hi all,

i patched the kernel with the patch for 2.6.14 with the option: /usr/src/linux # patch -p0 -l -i ../ibm_acpi.patch (which i copy&pasted)

they dont show me errors or so. but after i reboot and load the modul ibm_acpi i cant see any /proc/acpi/ibm/fan

whats the problem? copy&past ( tab -> space?) or is it a problem in my kernel config?

greetings and big thx from .ch,


system: ibm thinkpad t43p kernel: 2.6.14

--62.203.29.204 19:22, 9 Nov 2005 (CET)kru

You need to pass the "experimental=1" module parameter to ibm-acpi: 

# modprobe ibm_acpi experimental=1

--Thinker 21:01, 9 Nov 2005 (CET)

big thx!!! problem solved.

--62.203.29.204

Fan control does not work with Suse 10.1 ?

Hi,

I successfully installed and used the fan control script on my T43p with Suse 10.0.

Yesterday, I installed Suse 10.1 from scratch. Unfortunately fan control does not work with Suse 10.1:

\# echo level 2 > /proc/acpi/ibm/fan bash: echo: write error: Invalid argument

Are there any substantial differences between Suse 10.0 and 10.1 with respect to ibm_acpi?

  • You need to pass the fan_control=1 parameter to the thinkpad_acpi module when it's loaded into the kernel. This can be done manually with
# modprobe thinkpad_acpi fan_control=1

You'll have to read up on suse config to figure out how to do that automatically. With Gentoo it involves putting a file in /etc/modprobe.d/ then running # update-modules to have it update /etc/modprobe.conf. Other distros might have you just edit /etc/modprobe.conf directly but I wouldn't know. - Kelsin 01:16, 17 August 2008 (CEST)

Speed Control Patch for 2.6.18?

Hi All. I'm trying to apply the speed control patch to vanilla 2.6.18 but it looks like it failed. Anyone who can point me to a direction for 2.6.18 patch? Thanks

ibm-acpi-0.12a-2.6.17-fan.patch broken?

The code is not completed.

Retrieved from "https://www.thinkwiki.org/w/index.php?title=Talk:Patch_for_controlling_fan_speed&oldid=38641"